Skip to content

Deprecate type comments #20616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
cdce8p wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Deprecate type comments #20616

cdce8p wants to merge 1 commit into from

Conversation

@cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Jan 18, 2026

Ref #12947

@cdce8p cdce8p marked this pull request as draft January 18, 2026 17:52
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2026

Diff from mypy_primer, showing the effect of this PR on open source code:

tornado (https://github.com/tornadoweb/tornado)
+ tornado/util.py:239: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:240: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:244: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:263: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:275: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:283: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:293: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:310: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:326: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:332: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:350: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:406: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/util.py:441: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httputil.py:198: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httputil.py:484: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httputil.py:485: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httputil.py:488: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httputil.py:557: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httputil.py:563: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httputil.py:1201: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httputil.py:1221: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/log.py:142: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/log.py:235: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/template.py:310: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/template.py:368: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/template.py:424: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/template.py:736: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/template.py:979: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/template.py:994: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/options.py:299: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/options.py:341: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/options.py:446: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/options.py:558: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/options.py:564: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/locale.py:56: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/locale.py:231: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/locale.py:261: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/concurrent.py:60: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/concurrent.py:129: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/ioloop.py:157: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/ioloop.py:169: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/ioloop.py:285: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/ioloop.py:498: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/ioloop.py:508: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/ioloop.py:732: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/ioloop.py:739: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/ioloop.py:846: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/ioloop.py:915: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/netutil.py:103: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/netutil.py:519: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:154: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:211: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:217: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:367: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:375: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:380: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:381: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:382: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:383: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:527: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:528: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:563: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/gen.py:758: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/locks.py:42: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/locks.py:127: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/locks.py:200: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/locks.py:239: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/locks.py:422: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:125: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:253: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:257: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:261: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:262: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:263: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:264: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:267: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:268: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:271: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:272: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:277: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:279: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:535: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:609: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:733: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:814: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:856: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:1174: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:1262: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:1327: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/iostream.py:1339: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httpclient.py:179: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httpclient.py:297: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httpclient.py:342: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httpclient.py:536: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httpclient.py:627: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httpclient.py:629: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httpclient.py:655: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/tcpclient.py:68: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/tcpclient.py:71: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/tcpclient.py:72: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/tcpclient.py:73: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/tcpclient.py:76: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/tcpclient.py:327: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/queues.py:151: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/queues.py:162: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/queues.py:163: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/queues.py:199: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/queues.py:248: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/process.py:217: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/process.py:218: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/process.py:249: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/process.py:250: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/process.py:292: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/http1connection.py:153: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/http1connection.py:162: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/http1connection.py:163: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/http1connection.py:164: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/http1connection.py:169: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/http1connection.py:171: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/http1connection.py:210: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/http1connection.py:317: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/http1connection.py:318: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/http1connection.py:711: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/http1connection.py:787: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/curl_httpclient.py:59: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/curl_httpclient.py:64: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/curl_httpclient.py:67: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/curl_httpclient.py:68: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/curl_httpclient.py:275: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/tcpserver.py:131: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/tcpserver.py:132: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/tcpserver.py:133: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/tcpserver.py:372: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httpserver.py:205: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httpserver.py:268: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/httpserver.py:270: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/routing.py:246: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/routing.py:247: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/routing.py:341: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/routing.py:424: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ tornado/routing.py:483: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]

... (truncated 164 lines) ...

mongo-python-driver (https://github.com/mongodb/mongo-python-driver)
+ gridfs/synchronous/grid_file.py:1438: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ gridfs/asynchronous/grid_file.py:1450: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]

pydantic (https://github.com/pydantic/pydantic)
+ pydantic/v1/mypy.py:382: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ pydantic/v1/mypy.py:383: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]

meson (https://github.com/mesonbuild/meson)
+ mesonbuild/compilers/mixins/tasking.py:65:9: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ mesonbuild/compilers/mixins/tasking.py:66:9: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ run_mypy.py:130:5: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ run_mypy.py:131:5: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]

paasta (https://github.com/yelp/paasta)
+ paasta_tools/kubernetes/application/controller_wrappers.py:68: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]

sockeye (https://github.com/awslabs/sockeye)
+ sockeye/utils.py:287: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/utils.py:437: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/utils.py:583: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/utils.py:693: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/lr_scheduler.py:49: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/loss.py:46: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/layers.py:203: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/arguments.py:43: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/arguments.py:44: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/vocab.py:59: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/vocab.py:350: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/vocab.py:374: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/average.py:44: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/encoder.py:108: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/decoder.py:50: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/decoder.py:295: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:154: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:690: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:698: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1398: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1399: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1443: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1575: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1576: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1577: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1606: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1607: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1633: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1733: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1745: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/data_io.py:1746: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/model.py:163: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/model.py:172: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/model.py:173: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/model.py:174: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/model.py:513: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/model.py:517: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/model.py:580: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/model.py:807: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/model.py:808: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/model.py:809: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/lexicon.py:150: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/lexicon.py:175: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/evaluate.py:152: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/evaluate.py:171: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/evaluate.py:179: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/evaluate.py:186: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/generate_decoder_states.py:53: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/generate_decoder_states.py:123: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/generate_decoder_states.py:124: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/generate_decoder_states.py:128: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:100: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:102: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:148: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:149: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:170: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:171: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:172: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:192: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:194: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:264: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:336: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:402: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:714: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:720: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:848: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:850: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:857: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:859: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:860: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:865: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:913: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:914: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:945: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:1113: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/beam_search.py:1136: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:93: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:440: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:441: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:519: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:611: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:685: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:686: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:784: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:823: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:882: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:885: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:962: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:1033: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:1035: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:1119: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:1120: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/inference.py:1230: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/checkpoint_decoder.py:158: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/checkpoint_decoder.py:164: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/translate.py:79: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/scoring.py:80: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/scoring.py:115: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/scoring.py:117: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/scoring.py:129: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/scoring.py:132: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/training.py:132: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/training.py:210: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/training.py:466: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/training.py:931: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/train.py:737: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/train.py:1130: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ sockeye/train.py:1167: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]

imagehash (https://github.com/JohannesBuchner/imagehash)
+ imagehash/__init__.py:96: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:98: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:106: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:114: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:120: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:166: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:186: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:194: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:212: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:233: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:261: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:284: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:304: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:326: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:345: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:395: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:455: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:457: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:459: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:465: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:469: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:489: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:517: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:530: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:637: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:638: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:639: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:640: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:641: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:642: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ imagehash/__init__.py:643: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]

sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/transforms/i18n.py:423:9: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]

sympy (https://github.com/sympy/sympy)
+ sympy/__init__.py:52: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]

urllib3 (https://github.com/urllib3/urllib3)
+ src/urllib3/util/response.py:100: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]

dd-trace-py (https://github.com/DataDog/dd-trace-py)
+ ddtrace/internal/utils/fnv.py:23: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/fnv.py:35: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/attrdict.py:23: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/attrdict.py:29: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/serverless/__init__.py:6: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/serverless/__init__.py:15: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/serverless/__init__.py:23: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/serverless/__init__.py:34: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/dist_computing/utils.py:4: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/config.py:6: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/importlib.py:15: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/importlib.py:24: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/importlib.py:37: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/importlib.py:45: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/hostname.py:5: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/hostname.py:8: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/datastreams/encoding.py:10: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/datastreams/encoding.py:15: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/datastreams/encoding.py:21: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/datastreams/encoding.py:33: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/cache.py:28: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/cache.py:33: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/cache.py:40: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/cache.py:44: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/cache.py:63: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/cache.py:71: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/propagation/_utils.py:7: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/propagation/_utils.py:17: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/safety.py:22: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/safety.py:34: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/safety.py:39: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/safety.py:45: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/safety.py:64: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/safety.py:68: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/safety.py:77: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/safety.py:86: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/safety.py:90: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/safety.py:94: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/safety.py:107: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/glob_matching.py:12: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/glob_matching.py:17: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/forksafe.py:19: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/forksafe.py:20: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/forksafe.py:21: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/forksafe.py:44: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/forksafe.py:71: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/forksafe.py:86: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/forksafe.py:101: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/forksafe.py:104: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/forksafe.py:128: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/forksafe.py:130: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/forksafe.py:137: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/rate_limiter.py:45: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/rate_limiter.py:50: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/rate_limiter.py:53: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/retry.py:58: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/time.py:47: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/time.py:68: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/time.py:80: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/time.py:112: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/time.py:117: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/time.py:121: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/time.py:131: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/runtime/container.py:76: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/runtime/collector.py:27: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/runtime/collector.py:28: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/runtime/collector.py:31: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/runtime/collector.py:58: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/service.py:16: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/service.py:18: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/service.py:19: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/wrapping/context.py:425: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/runtime/metric_collectors.py:19: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/periodic.py:41: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/periodic.py:46: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/periodic.py:48: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/periodic.py:56: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/periodic.py:68: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/periodic.py:75: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/periodic.py:77: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/periodic.py:87: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/periodic.py:95: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/http.py:16: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/http.py:18: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/runtime/tag_collectors.py:20: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/llmobs/_log_writer.py:43: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/llmobs/_log_writer.py:47: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/llmobs/_log_writer.py:50: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/llmobs/_log_writer.py:51: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/llmobs/_log_writer.py:52: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/llmobs/_log_writer.py:53: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/llmobs/_log_writer.py:54: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/llmobs/_log_writer.py:65: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/llmobs/_log_writer.py:77: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/llmobs/_log_writer.py:81: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/uds.py:13: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/uds.py:15: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/uds.py:16: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/uds.py:17: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/uds.py:23: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ docs/conf.py:318: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/wrappers.py:12: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/wrappers.py:20: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/formats.py:28: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/formats.py:53: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/formats.py:102: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/formats.py:110: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/formats.py:135: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/internal/utils/formats.py:144: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/ext/git.py:101: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/ext/git.py:106: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/ext/git.py:121: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/ext/git.py:153: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/ext/git.py:175: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]
+ ddtrace/ext/git.py:182: error: Using type comments with mypy is deprecated, use inline annotations instead  [misc]

... (truncated 237 lines) ...```

@emmatyping
Copy link
Member

emmatyping commented Jan 19, 2026

I think if we are going to deprecate type comments we will absolutely need to provide a switch to let folks silence this message. Based on the primer output, it seems (expectedly) that the usage of type comments are pervasive in some code bases. These code bases should be allowed to ignore this deprecation for now. I also think if we are going to deprecate type comments loudly we should link from the deprecation message to a page in the documentation about how to migrate a codebase using type comments to annotations automatically (or at least, mostly automatically). This page should mention things like the libcst codemod https://libcst.readthedocs.io/en/latest/codemods.html#libcst.codemod.visitors.ApplyTypeAnnotationsVisitor

@JukkaL
Copy link
Collaborator

JukkaL commented Jan 21, 2026

We should probably start with a new opt-in error code about type comments and explaining that we are planning to (soft) deprecate type comments eventually.

I'm working on a new parser for mypy and it doesn't yet fully support type comments, but it may be worth it to continue to support them still in the future, if many old type comments are still around. I think I can add full support for type comments to the new parser, it's just some extra work.

We might require some flag to even parse type comments at some point, but this would be a backward compatibility break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cdce8p @emmatyping @JukkaL